On 05/11/2015 12:58 AM, Justin Ossevoort wrote: > The current guest-fstrim support only returns an error if some > mountpoint was unable to be trimmed, skipping any possible additional > mountpoints. The result of the TRIM operation itself is also discarded. > > This change returns a per mountpoint result of the TRIM operation. If an > error occurs on some mountpoints that error is returned and the > guest-fstrim continue with any additional mountpoints. > > The returned values for errors, minimum and trimmed are dependant on the > filesystem, storage stacks and kernel version. > > Signed-off-by: Justin Ossevoort <jus...@quarantainenet.nl> > --- > qga/commands-posix.c | 54 > ++++++++++++++++++++++++++++++++++++++-------------- > qga/commands-win32.c | 4 +++- > qga/qapi-schema.json | 32 ++++++++++++++++++++++++++++--- > 3 files changed, 72 insertions(+), 18 deletions(-) >
> @@ -437,12 +461,14 @@ > # fragmented free space, although not all blocks will be discarded. > # The default value is zero, meaning "discard every free block". > # > -# Returns: Nothing. > +# Returns: A @GuestFilesystemTrimResponse which contains the > +# status of all trimmed paths. Maybe mention (since 2.4) as part of the Returns: line. > # > -# Since: 1.2 > +# Since: 2.4 NACK to this hunk. The command itself has existed since 1.2, it is only the returns type that has changed in 2.4. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
