On 26/05/2015 17:49, Alexey Kardashevskiy wrote: >> >> It's very little used, but that's just because it's not too common. >> There's nothing wrong with it. :) >> >> If you do del/set_size/add, you may want to put a >> memory_region_transaction_{begin,commit} around the whole dance. > > > Here I lost you again :) > Why? These are IOMMU MRs -> they are dynamic, what will begin()/commit() > change here?
If you don't add them, the memory core may create two or three different flatviews. With begin/commit, it will only do one change. It's just an optimization. Paolo