On 05/26/2015 03:25 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> On 05/22/2015 05:36 AM, Markus Armbruster wrote: >>> All QMP commands use the "new" handler interface (mhandler.cmd_new). >>> Most HMP commands still use the traditional interface (mhandler.cmd), >>> but a few use the "new" one. Complicates handle_user_command() for no >>> gain, so I'm converting these to the traditional interface. >>>
>> >>> + >>> + devfn = (int)qdict_get_int(qdict, "devfn"); >> >> Code motion, so the problem is pre-existing, but this cast is unneeded. >> Up to you if you want to clean it up now. > > While I occasionally do fold cleanups into mechanical changes, e.g in > PATCH 15, I'm reluctant to fold them into code motion. I totally agree - mixing cleanups into code motion makes the motion harder to review. If it gets cleaned up, it should be as a separate patch, at which point it starts to be out of scope of the goal of this series, and better as a separate patch to qemu-trivial or to the PCI tree. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
