Am 15.05.2015 um 08:59 schrieb Peter Crosthwaite: > On Sun, May 10, 2015 at 11:29 PM, Peter Crosthwaite > <crosthwaitepe...@gmail.com> wrote: >> The helper function namespace is going to be tricky. I haven't tackled the >> problem just yet, but looking for ideas on how we can avoid prefacing all >> helpers with arch prefixes to avoid link-time collisions because multiple >> arches use the same helper names. > > Ok so have half a plan here now for the helper link-time namespace > problem. The top level HELPER() macro can be patched to glue() in an > architecture name set by cpu.h. The every use of HELPER(foo) will be > namespace collision free. The catch? Some arches mass-use literal > helper_foo for defs and calls.
I've always disliked that inconcistency, so +1 for forcing the use of HELPER(). Will also make it easier to switch the CPU argument some day. Cheers, Andreas > Fortunately ARM is well behaved and > only has about 4 usages so thats an easy convert. Microblaze has more. > It will be a reasonably simple (but tedious) scripted changed to > convert uses and definitions of helper_foo to HELPER(foo) but it saves > on the verbosity of having to go in and preface everything (all of > callsites, definitions and helper.h defs themselves). > > Regards, > Peter -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
