On 05/12/2015 06:02 AM, Markus Armbruster wrote: > Type "hubport" is valid only with -netdev. Unfortunately, that's > detected late and the error message doesn't explain why: > > $ qemu-system-i386 -net hubport,id=foo,hubid=0 > qemu-system-i386: -net hubport,id=foo,hubid=0: Device 'hubport' could not > be initialized > > Improve the error message to "Parameter 'type' expects a net type". > > Not fixed: -net hubport without the parameters required by -netdev > hubport still asks for those parameters: > > $ qemu-system-i386 -net hubport > qemu-system-i386: -net hubport: Parameter 'hubid' is missing > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > net/hub.c | 5 +---- > net/net.c | 5 +++++ > 2 files changed, 6 insertions(+), 4 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
