On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: > The qemu-io tool does not check if the image is encrypted so > historically would silently corrupt the sectors by writing > plain text data into them instead of cipher text. The earlier > commit turns this mistake into a fatal abort, so check for > encryption and prompt for key when required.
Doesn't that mean that 'git bisect' gives a crashing qemu-io for 3 patches? Should this be rearranged so that 1/5 comes after this to avoid triggering the abort? > > This enables us to add unit tests to ensure we don't break > the ability of qemu-img to convert existing encrypted qcow2 > files into a non-encrypted format. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > qemu-io.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
