On 05/11/2015 06:48 AM, Michael S. Tsirkin wrote: > From: Zhu Guihua <zhugh.f...@cn.fujitsu.com> > > When memory hot unplug fails, this patch adds support to send > QMP event to notify mgmt about this failure. > > Reviewed-by: Igor Mammedov <imamm...@redhat.com> > Signed-off-by: Zhu Guihua <zhugh.f...@cn.fujitsu.com> > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > qapi/event.json | 14 ++++++++++++++ > hw/acpi/memory_hotplug.c | 10 +++++++++- > docs/qmp/qmp-events.txt | 17 +++++++++++++++++ > trace-events | 1 + > 4 files changed, 41 insertions(+), 1 deletion(-)
I missed reviewing this earlier; and since it is now in a PULL request,
you'll need a followup patch:
> +
> +##
> +# @MEM_UNPLUG_ERROR
> +#
> +# Emitted when memory hot unplug error occurs.
> +#
> +# @device: device name
> +#
> +# @msg: Informative message
> +#
> +# Since: 2.4
> +##
> +{ 'event': 'MEM_UNPLUG_ERROR',
The name here...
> +++ b/docs/qmp/qmp-events.txt
> @@ -226,6 +226,23 @@ Example:
> { "event": "GUEST_PANICKED",
> "data": { "action": "pause" } }
>
> +MEM_HOT_UNPLUG_ERROR
...needs to be the same one used here.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
