On 08/05/2015 19:47, Dimitris Aragiorgis wrote: > Hi all, > > These four patches make slight changes to the way QEMU handles SCSI > generic devices to fix a number of small problems. > > I am sending them against the master branch, since I don't know if they > can be considered bugfixes. > > Thanks, > dimara > > v2: > * remove duplicate check for sg inside iscsi_co_flush() > * remove DEBUG_BLOCK_PRINT in block/raw-posix.c > * use DPRINTF for debugging in block/raw-posix.c > > PS: Paolo suggested to use a tracepoint inside hdev_is_sg() but I chose > DPRINTF > instead. It would make sense to add a tracepoint for bdrv_is_sg() (just like > most bdrv_* commands) but this is too much for now since it just returns the > bs->sg flag (and is not an actual driver function). If you insist I'll change > it in v3. > > Dimitris Aragiorgis (5): > block: Use bdrv_is_sg() everywhere > Fix migration in case of scsi-generic > raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT > raw-posix: Use DPRINTF for DEBUG_FLOPPY > raw-posix: Introduce hdev_is_sg() > > block.c | 6 ++--- > block/io.c | 2 +- > block/iscsi.c | 4 --- > block/raw-posix.c | 75 > +++++++++++++++++++++++++++++------------------------ > 4 files changed, 45 insertions(+), 42 deletions(-) >
I am okay with the debug printf, even though the problem with debug printfs is that no one uses them and they bitrot. Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> Paolo
