Re: [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg.

[Richard Henderson]

On 04/10/2010 10:09 AM, takas...@ops.dti.ne.jp wrote:

2nd arg of page_set_flags() should be start+size, but size.

Signed-off-by: Takashi YOSHII<takas...@ops.dti.ne.jp>

Acked-by: Richard Henderson <r...@twiddle.net>

---
  linux-user/syscall.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a03e432..26c0fb4 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2752,7 +2752,7 @@ static inline abi_long do_shmdt(abi_ulong shmaddr)
      for (i = 0; i<  N_SHM_REGIONS; ++i) {
          if (shm_regions[i].start == shmaddr) {
              shm_regions[i].start = 0;
-            page_set_flags(shmaddr, shm_regions[i].size, 0);
+            page_set_flags(shmaddr, shmaddr + shm_regions[i].size, 0);
              break;
          }
      }