On 05/07/2015 09:26 AM, Paolo Bonzini wrote: > Right now, NBD includes potentially platform-specific error values in > the wire protocol. > > Luckily, most common error values are more or less universal: in > particular, of all errno values <= 34 (up to ERANGE), they are all > the same on supported platforms except for 11 (which is EAGAIN on > Windows and Linux, but EDEADLK on Darwin and the *BSDs).
Well, this is not true on GNU Hurd, but to my knowledge no one has tried to compile qemu on Hurd. > > + /* NBD errors should be universally equal to the corresponding > + * errno values, check it here. > + */ > + QEMU_BUILD_BUG_ON(EPERM != 1); And this is (probably not the first place) where qemu compilation would fail on Hurd. At any rate, I see no reason to hold up the patch on that ground. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
