Quoting Paolo Bonzini (2015-04-30 09:08:10) > > > On 29/04/2015 21:20, Michael Roth wrote: > > + if (spapr->dr_phb_enabled) { > > + for (i = 0; i < SPAPR_DRC_MAX_PHB; i++) { > > + sPAPRDRConnector *drc = > > + spapr_dr_connector_new(OBJECT(machine), > > + SPAPR_DR_CONNECTOR_TYPE_PHB, i); > > + qemu_register_reset(spapr_drc_reset, drc); > > + } > > + } > > Is this needed because drc is busless? Then I think it should be done > in device_set_realized (and the matching qemu_unregister_reset too).
You mean move the qemu_register_reset() to DRC->realize()? Don't recall if there was a reason I did it this way, but that does seem a lot cleaner. And yah, no bus for DRCs, so we're not hooked into qbus_reset_all_fn() > > Paolo >