On Tue, 28 Apr 2015 14:16:40 +0100 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 28 April 2015 at 14:13, Michael S. Tsirkin <m...@redhat.com> wrote: > > The patches look correct to me too, but I want s390 > > cleaned up so it does not include COMMON_FEATURES > > in 100 places, and I prefer merging it all together. > > It seems a bit harsh to ask Shannon to do s390 cleanup when > he doesn't have any access to s390 guests or test cases... > Making S390 put COMMON_FEATURES in the right places seems > to me like a separate bit of s390-specific cleanup. Yep, see my other reply... I'm not quite sure what's wrong with event_idx on virtio-blk for s390-virtio, or I would gladly make this consistent with the other transports. Any hints appreciated :)