On Fri, Apr 24, 2015 at 11:52:00AM -0400, John Snow wrote: > > On 04/24/2015 04:32 AM, Kashyap Chamarthy wrote:
[. . .] > These: > > > block-dirty-bitmap-add > > block-dirty-bitmap-clear > > > > Aren't merged yet, so it might be a little confusing. Yeah, I expected someone to call that out, that's the reason I added the NB at the end of the commit message which explicitly states that these will be usable once your series (linked below) is merged, hoping that'd clarify. > We could tack this on to the end of the transaction series if you'd > like, and hopefully that all goes in at once before 2.4. That works too. If it's preferable, I can respin this to remove the mention of above two commands and resubmit a v3. -- /kashyap > >NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-clear' commands > >will be available once the in-review "transactionless incremental > >backup" patch series[1] is merged upstream. > > > >[1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html > > > >Signed-off-by: Kashyap Chamarthy <kcham...@redhat.com> > >Reviewed-by: Eric Blake <ebl...@redhat.com> > >--- > > From v1 -> v2: > > > > - Update the "NB" part of the commit message by removing the duplicate > > command entry and add the missing one ('block-dirty-bitmap-clear') > > - Fix grammer per Eric Blake's review: s/refer/refer to the > >--- > > qmp-commands.hx | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > >diff --git a/qmp-commands.hx b/qmp-commands.hx > >index > >3a42ad0bffeb23778f877410f6e2038943da46c0..b7fe31ca37afe0f4ae8f4b6f7be5d379b361b1b8 > > 100644 > >--- a/qmp-commands.hx > >+++ b/qmp-commands.hx > >@@ -1200,11 +1200,14 @@ SQMP > > transaction > > ----------- > > > >-Atomically operate on one or more block devices. The only supported > >operations > >-for now are drive-backup, internal and external snapshotting. A list of > >-dictionaries is accepted, that contains the actions to be performed. > >-If there is any failure performing any of the operations, all operations > >-for the group are abandoned. > >+Atomically operate on one or more block devices. Operations that are > >+currently supported: drive-backup, blockdev-backup, > >+blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > >+block-dirty-bitmap-add, block-dirty-bitmap-clear (refer to the > >+qemu/qapi-schema.json file for minimum required QEMU versions for these > >+operations). A list of dictionaries is accepted, that contains the > >+actions to be performed. If there is any failure performing any of the > >+operations, all operations for the group are abandoned. > > > > For external snapshots, the dictionary contains the device, the file to > > use for > > the new snapshot, and the format. The default format, if not specified, is > >
