On 04/23/2015 04:57 PM, miny...@acm.org wrote: > The major changes from last time are:
That says this series should probably be named v2 (git format-patch/send-email -v2) or later, as part of the subject line. If the previous version is more than a couple weeks ago, it's also nice (but not required) to provide a URL to the archives of the previous discussion. > > * Don't use callbacks for adding firmware tables, provide binary > blobs instead. > > * Add the SSDT as a separate table. > > * Modify the BIOS tests to test for the IPMI tables. > Also, you might want to use git format-patch --cover-letter, which helps form a 00/17 letter with a diffstat pre-filled; the diffstat gives reviewers a quick glance at what files are touched, and how many lines of code are being impacted, which makes it easier to decide when to schedule a review for the series. More patch submission hints at: http://wiki.qemu.org/Contribute/SubmitAPatch -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
