Hi Leon, On 04/23/2015 07:00 AM, Leon Alrae wrote: > Hi Christopher, > > On 09/04/2015 18:57, Peter Maydell wrote: >> On 9 April 2015 at 18:23, Christopher Covington >> <christopher.coving...@linaro.org> wrote: >>> On Fri, Mar 27, 2015 at 12:40 PM, Peter Maydell >>> <peter.mayd...@linaro.org> wrote: >>>> You need to have the semihosting_enabled check here rather >>>> than in the do_interrupt code, because otherwise we won't >>>> behave correctly in the disabled case. >>> >>> Do you have suggestions for getting semihosting_enabled defined in >>> translate-a64.c? I'm likely doing something dumb, but while #include >>> "sysemu/sysemu.h" at first seemed like the obvious approach, and >>> appears to work for -softmmu, I'm getting errors with that when >>> building -linux-user. >> >> sysemu.h is an ugly grab-bag of things that are specific to the >> system emulator config. Semihosting is always enabled for linux-user, >> so it doesn't have an equivalent switch. >> >> Let's clean this up a bit, by creating a new include/exec/semihost.h, > > Do you happen to have this clean up available somewhere? I just want to > make sure I'm not duplicating the work as my patches will touch the same > area.
I'm afraid I've not yet had a chance to clean this up, and I'm not sure when I'll be able to get to it. Chris -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
