On Tue, 21 Apr 2015 14:53:54 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> On Tue, Apr 21, 2015 at 12:33:36PM +0100, Peter Maydell wrote: > > On 21 April 2015 at 11:09, Michael S. Tsirkin <m...@redhat.com> wrote: > > > On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote: > > >> A predefined scope in the ACPI specs is precede with a backslash. > > >> > > >> Signed-off-by: Gal Hammer <gham...@redhat.com> > > > > > > s/precede/preceded/ > > > > > > This is correct, but do we need this in 2.3? > > > I'm split on this. Thoughts? > > > If yes, commit log needs better explanation on what > > > the effect on guests is. > > > > Unless the effect is absolutely catastrophic you've missed > > the boat for 2.3, and should settle for 2.4 + cc:stable. > > > > thanks > > -- PMM > > I rechecked a bunch of guests and they all seem to behave identically > with and without the patch. > 2.4 it is. Yep, it's cosmetic change, since that _SB was at the top level it's automatically attributed to root scope. Having explicit root in name doesn't hurt though and makes it consistent with other _SB declarations in the code. > > Thanks. >
