On 27.03.2015 20:19, John Snow wrote:
These structures are misnomers, somewhat.(1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the BlkActionState, above. This name might imply a 'BdrvAction' or a 'BdrvActionState', which there isn't. Rename this to 'BlkActionOps' to match 'BlkActionState'. Lastly, update the surrounding in-line documentation and comments to reflect the current nature of how Transactions operate. This patch changes only comments and names, and should not affect behavior in any way. Signed-off-by: John Snow <js...@redhat.com> --- blockdev.c | 114 ++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 64 insertions(+), 50 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
