On 04/08/2015 05:37 AM, Juan Quintela wrote: > Liang Li <liang.z...@intel.com> wrote: >> Put the three parameters related to multiple thread (de)compression >> into an int array, and use an enum type to index the parameter. >> >> Signed-off-by: Liang Li <liang.z...@intel.com> >> Signed-off-by: Yang Zhang <yang.z.zh...@intel.com> > > Reviewed-by: Juan Quintela <quint...@redhat.com> > > > BTW, for the libvirt people, what do you think about moving the other > parameters here, and make the other accessors deprecated? > > I mean here: > - xbzrle_cache_size > -> get mbps > -> set/get migration_speed > -> get/set migration_downtime > -> autoconverge? > > You get the idea.
Setting multiple bits through one command is nicer. Libvirt will still have to keep the code for driving older qemu, but I'm not opposed to consolidation. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
