Am 05.04.2010 16:53, schrieb Christoph Hellwig: > BDRV_O_FILE is only used to communicate between bdrv_file_open and bdrv_open. > It affects two things: first bdrv_open only searches for protocols using > find_protocol instead of all image formats and host drivers. We can easily > move that to the caller and pass the found driver to bdrv_open. Second > it is used to not force a read-write open of a snapshot file. But we never > use bdrv_file_open to open snapshots and this behaviour doesn't make sense > to start with. > > qemu-io abused the BDRV_O_FILE for it's growable option, switch it to > using bdrv_file_open to make sure we only open files as growable were > we can actually support that. > > This patch requires Kevin's "[PATCH] Replace calls of old bdrv_open" to > be applied first. > > Signed-off-by: Christoph Hellwig <h...@lst.de>
Looks like a step in the right direction. Acked-by: Kevin Wolf <kw...@redhat.com>
