On 04/10/2015 02:59 PM, Eric Blake wrote: > Defaulting a parameter to True, then having all callers omit > or pass an explicit True for that parameter, is pointless. > Looks like it has been dead since introduction in commit 06d64c6. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > scripts/qapi-visit.py | 36 ++++++++++++++++-------------------- > 1 file changed, 16 insertions(+), 20 deletions(-)
> @@ -510,8 +507,7 @@ exprs = parse_schema(input_file)
> # for built-in types in our header files and simply guard them
> fdecl.write(guardstart("QAPI_VISIT_BUILTIN_VISITOR_DECL"))
> for typename in builtin_types.keys():
Sorry; this doesn't apply to current master. I'll send a v2 that
doesn't depend on my pending qapi nested struct series.
> - fdecl.write(generate_declaration(typename, None, genlist=True,
> - builtin_type=True))
> + fdecl.write(generate_declaration(typename, None, builtin_type=True))
> fdecl.write(guardend("QAPI_VISIT_BUILTIN_VISITOR_DECL"))
>
> # ...this doesn't work for cases where we link in multiple objects that
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
