On 04/03/2015 07:18 AM, Peter Maydell wrote:
On 2 April 2015 at 20:31, Ed Maste <ema...@freebsd.org> wrote:
On 1 April 2015 at 18:45, Peter Maydell <peter.mayd...@linaro.org> wrote:
Also irritating is the way it silently requires
the binary to have a name in the shape it was
expecting, which can catch you out if you were
trying to set it to a wrapper shell script that
invokes valgrind or something...
I don't really have enough context to propose a good user-facing
message with a tip for manually executing this, so hopefully someone
else can provide one. I just noticed one other instance that already
had an assertion on getenv("QTEST_QEMU_BINARY") being non-null.
Yes, that was just me venting about something that caught me
out in the past rather than review comment on this patch :-)
Sorry for any confusion.
-- PMM
I'll pull this into ide-next for 2.4 -- I have some ahci-test things to
submit anyway.
I'll touch up the user facing error messages in a later patch and hit a
few of the startup assertions all at once.
Thanks.
--js