>>> > Hi Kirk, > > Am 30.03.2015 um 22:44 schrieb Kirk Allan: >> Ping. >> >> Looking for feedback anyone might have regarding this patch. > > I would recommend to make the patch smaller and the commit message more > intuitive by splitting off the configure changes into its own patch > (remember to include a short cover letter then).
OK, I'll do that. > It feels strange to > have a new configure option for a single -D though... Can't this value > be overridden via --extra-cflags=-D_WINNT_WINVER=0xf00 already? Good point. I'll create a new patch that used --extra-cflags to do the job. > > CC'ing some people that know about Windows might help, too. Stefan W. > comes to mind. > > Also note that we're in Hard Freeze for 2.3 at the moment, which shifts > people's attention to bug fixes. > > Regards, > Andreas
