On 03/26/2015 01:52 AM, Markus Armbruster wrote: >>>> I'm not sure if it is okay to assert GPLv2+ licensing without an >>>> explicit Copyright, but as I am not the original author, I don't >>>> know who to attribute any original Copyright to. Advice? Should >>>> I split the license addition to a separate patch? >> >> No thoughts to this question? > > Missed it. > > I wish we didn't need to clutter copyright and licensing boiler plate > everywhere, but I accept it's the prudent thing to do in a tree with so > many differently licensed parts. > > Making GPLv2+ explicit is obviously fine, because anything without an > explicit licensing note is GPLv2+ (see ./LICENSE). That leaves the > copyright part, as you say. > > According to git-log, the file was created by Michael Roth. git-blame > blames 219 out of 590 lines in current master on his initial commit. > > $ git-blame -w master docs/qapi-code-gen.txt | cut -c 11-28 | sort | uniq -c > | sort -nr
Nice, but the 'cut' renders it not quite reusable when column widths
vary on other files or authorship information. 'git blame --help' suggests:
kept by the reader. The --line-porcelain option can be used to output
full commit information for each line, allowing simpler (but less
efficient) usage like:
# count the number of lines attributed to each author
git blame --line-porcelain file |
sed -n 's/^author //p' |
sort | uniq -c | sort -rn
So with the updated formula, I also checked doc/qmp/qmp-spec.txt:
201 Luiz Capitulino
55 Markus Armbruster
17 Paolo Bonzini
which is entirely Red Hat (a bit easier to handle).
>
> If you want to add a copyright note, I suggest to steal one from
> Michael's work elsewhere, and update it for later major contributors.
>
> Here's my stab at it:
>
> = How to use the QAPI code generator =
>
> Copyright IBM Corp. 2011
> Copyright (C) 2012-2015 Red Hat, Inc.
>
> Authors:
> Michael Roth <mdr...@linux.vnet.ibm.com>
> Kevin Wolf <kw...@redhat.com>
> Markus Armbruster <arm...@redhat.com>
> Eric Blake <ebl...@redhat.com>
>
> This work is licensed under the terms of the GNU GPL, version 2 or later.
> See the COPYING file in the top-level directory.
>
> == Introduction ==
>
> QAPI is a native C API within QEMU which provides management-level
> functionality to internal and external users. For external
>
> The Authors paragraph is informational and could be omitted without
> compromising the copyright note.
I prefer omitting Authors information (it is too easy to become stale).
I'll split this into a separate patch, as part of my v6.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
