On 10/03/2015 06:47, David Gibson wrote: >> > +void migrate_send_rp_message(MigrationIncomingState *mis, >> > + enum mig_rpcomm_cmd cmd, >> > + uint16_t len, uint8_t *data) > Using (void *) for data would avoid casts in a bunch of the callers.
Could also use uint8_t in the callers and replace cpu_to_be32 with stl_be_p. This makes it harder to send stuff with the wrong endianness. Paolo