Peter Maydell <peter.mayd...@linaro.org> writes: > On 23 March 2015 at 19:09, Markus Armbruster <arm...@redhat.com> wrote: >> Due to misuse of drive_get_next(), -device sdhci can connect to a >> -drive if=sd,... If you can't see what's wrong here, check out the >> FIXME in sdhci_initfn() and the commit that added it. >> >> We can't fix this in time for the release, but since the device is new >> in 2.3, we can disable it before this mistake becomes ABI: set >> cannot_instantiate_with_device_add_yet. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> hw/sd/sdhci.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c >> index f056c52..ab13505 100644 >> --- a/hw/sd/sdhci.c >> +++ b/hw/sd/sdhci.c >> @@ -1254,6 +1254,8 @@ static void sdhci_pci_class_init(ObjectClass *klass, >> void *data) >> set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); >> dc->vmsd = &sdhci_vmstate; >> dc->props = sdhci_properties; >> + /* Reason: realize() method uses drive_get_next() */ >> + dc->cannot_instantiate_with_device_add_yet = true; >> } > > This is basically saying "this device won't work in this > release", right?
Yes, because with this patch, you can use it only from code, and code isn't using it right now.
