On Wed, Feb 25, 2015 at 04:51:51PM +0000, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Looks ok, apart from a misspelled comment:
[snip]
> + /*
> + * We need the whole of RAM to be truly empty for postcopy, so things
> + * like ROMs and any data tables built during init must be zero'd
> + * - we're going to get the copy from the source anyway.
> + * (Precopy will just overwrite this data, so doesn't need the discard)
> + */
> + if (postcopy_ram_discard_range(mis, host_addr, (host_addr + length -
> 1))) {
> + return -1;
> + }
> +
> + /*
> + * We also need the area to be normal 4k pages, not huge pages
> + * (otherwise we can't be sure we can atopically place the
s/atopically/atomically/
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpAUMS8idGZH.pgp
Description: PGP signature
