On 22 March 2015 at 09:49, Stefan Weil <s...@weilnetz.de> wrote:
> Am 22.03.2015 um 10:09 schrieb Waldemar Brodkorb:
>>
>> + case 0x1c:
>
>
> Add /* SIMR */ comment behind case statement like it was done for SWIACK.
> Then either add a /* fall through */ comment or a return 0 (to satisfy
> static
> code analyzers).
No, I don't believe you need a /* fall through */ comment here:
analysers are smart enough to realize that two 'case foo:'
lines with no code at all between them means a deliberate
fall through. It's only where you have
case foo:
some_code();
case bar:
more_code();
that you need to add the comment to indicate that the fall through
was intentional.
Just writing
case 0x1c: /* SIMR */
case 0x1d: /* CIMR */
return 0;
should be good enough.
-- PMM
