On Thu, Mar 19, 2015 at 09:52:59AM +0800, Zhu Guihua wrote: > > On 03/16/2015 09:58 PM, Michael S. Tsirkin wrote: > >On Mon, Mar 16, 2015 at 04:58:13PM +0800, Zhu Guihua wrote: > >>From: Tang Chen <tangc...@cn.fujitsu.com> > >> > >>Add a new API named acpi_memory_slot_status() to obtain a single memory > >>slot status. Doing this is because this procedure will be used by other > >>functions in the next coming patches. > >> > >>Signed-off-by: Tang Chen <tangc...@cn.fujitsu.com> > >>Signed-off-by: Zhu Guihua <zhugh.f...@cn.fujitsu.com> > >It's generally only OK to add API in a separate > >patch from its use if the API is well documented. > >There's 0 documentation here, so please just squash this > >with the user so one can review without jumping > >back and forth. > > The new API will be used in several places. If I squash this with the > user, I think the patch will be too large. > > So I think it is better to add documentation here. what's your opinion? > > Thanks, > Zhu
That's fine too.
