On 2015/3/18 15:02, Gerd Hoffmann wrote:
> Hi,
>
>> -static void uhci_reset(void *opaque)
>> +static void uhci_reset(DeviceState *dev)
>> {
>> - UHCIState *s = opaque;
>> + PCIDevice *d = PCI_DEVICE(dev);
>> + UHCIState *s = DO_UPCAST(UHCIState, dev, d);
>
> Uh, oh, DO_UPCAST() is long deprecated. There are other instances of
> this in the uhci emulation though, so we need a cleanup & qom-ify pass
> for the code anyway. So I think it's ok for a bugfix patch.
>
Yes, I noticed that, but I haven't a good idea for qom-ifing uhci. :)
May we refer to the realization of ehci ?
> I'll queue it up (and the other two too of course).
>
Thanks.
Regards,
-Gonglei
