* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:48PM +0000, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > > > When postcopy calls qemu_savevm_state_complete it's not really > > the end of migration, so skip: > > Given that, maybe the name should change..
The name reflects that it calls the save_live_complete method on each device, so if we wanted to remove the 'complete' from the name we'd probably want to change the method name everywhere; and anyway it does complete most devices; the only exception are devices that are postcopiable. > > a) Finishing postcopiable iterative devices - they'll carry on > > b) The termination byte on the end of the stream. > > > > We then also add: > > qemu_savevm_state_postcopy_complete > > which is called at the end of a postcopy migration to call the > > complete methods on devices skipped in the _complete call. > > > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > Otherwise, > > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> Thanks. Dave > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ > _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
