On Mon, Mar 29, 2010 at 20:16, Kevin Wolf <kw...@redhat.com> wrote:
> Am 27.03.2010 13:47, schrieb Aurelien Jarno:
>> On Fri, Mar 19, 2010 at 12:59:24PM +0800, TeLeMan wrote:
>>> The "params" is never NULL and the usb hid devices have no params.
>>
>> This looks plainly wrong. With your patch, usb devices which don't
>> accept parameters, will accept and ignore them.
>>
>> What are you trying to fix here?
>
> It looks like it's fixing -usbdevice tablet (and keyboard/mouse) which
> currently fails like this:
>
> qemu-system-x86_64: usbdevice tablet accepts no params
> qemu: could not add USB device 'tablet'
>
> He's correct in that params is never NULL (if it was NULL it's set to an
> empty string some lines earlier, introduced by 702f3e0f), so
> usb_create_simple is never called. Maybe the right fix is to check for
> *params instead of params now?
Yes, you are right. I did a new patch for it.
