Re: [Qemu-devel] [PATCH 1/5] target-arm: convert check_ap to get_rw_prot

[Andrew Jones]

On Tue, Mar 10, 2015 at 03:12:20PM +0000, Peter Maydell wrote:
> On 12 February 2015 at 15:05, Andrew Jones <drjo...@redhat.com> wrote:
> > +        *prot = get_rw_prot(env, mmu_idx, ap, domain_prot);
> > +        *prot |= *prot && !xn ? PAGE_EXEC : 0;
> 
> I'm not a great fan of complicated ?: expressions, incidentally;
> I think this is clearer to read as
>    if (*prot && !xn) {
>        *prot |= PAGE_EXEC;
>    }
> 
> -- PMM

OK, I'll change it if we need a v2.

Thanks,
drew