Am 10.03.2015 um 13:42 schrieb Eduardo Habkost: > On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote: >> Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: >>> Instead of passing icc_bridge from the PC initialization code to >>> cpu_x86_create(), make the PC initialization code attach the CPU to >>> icc_bridge. >>> >>> The only difference here is that icc_bridge attachment will now be done >>> after x86_cpu_parse_featurestr() is called. But this shouldn't make any >>> difference, as property setters shouldn't depend on icc_bridge. >>> >>> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> >> >> Looks okay to me, >> >> Reviewed-by: Andreas Färber <afaer...@suse.de> >> >> But using this smaller patch will still make inlining pc_new_cpu(), >> where you are moving it to, bigger diffstat-wise (WIP). > > I just see this it as a reason to not inline pc_new_cpu(). :)
Did you actually read my code? cpu_x86_create() does not allow in-place initialization, in addition to doing the realized=true. Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
