On 2015/3/8 19:16, Marcel Apfelbaum wrote: > Add encoding for ACPI DefOr Opcode. > > Reviewed-by: Igor Mammedov <imamm...@redhat.com> > Signed-off-by: Marcel Apfelbaum <mar...@redhat.com> > --- > hw/acpi/aml-build.c | 10 ++++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 0d14561..603c0c4 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -448,6 +448,16 @@ Aml *aml_and(Aml *arg1, Aml *arg2) > return var; > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefOr */ > +Aml *aml_or(Aml *arg1, Aml *arg2) > +{ > + Aml *var = aml_opcode(0x7D /* OrOp */); > + aml_append(var, arg1); > + aml_append(var, arg2); > + build_append_int(var->buf, 0x00); /* NullNameOp */ Hi,
I notice that MST has sent a patch which uses build_append_byte instead of build_append_int. Maybe we can fix this patch before apply. Thanks, Shannon > + return var; > +} > +