On 02/16/2015 07:44 AM, Markus Armbruster wrote: > Return the Error object instead of reporting it with > qerror_report_err(). > > Change callers that assume the function can't fail to pass > &error_abort, so that should the assumption ever break, it'll break > noisily. > > Turns out all callers outside its unit test assume that. We could > drop the Error ** argument, but that would make the interface less > regular, so don't. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > include/qemu/option.h | 4 ++-- > net/net.c | 4 ++-- > tests/test-qemu-opts.c | 6 +++--- > util/qemu-option.c | 11 +++++------ > vl.c | 15 ++++++++++----- > 5 files changed, 22 insertions(+), 18 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature