On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote: > > > On 15/02/2015 12:39, Michael S. Tsirkin wrote: > > Drop duplicated code. > > > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > --- > > include/hw/virtio/virtio-scsi.h | 120 > > +++------------------------------------- > > hw/scsi/virtio-scsi.c | 1 + > > 2 files changed, 10 insertions(+), 111 deletions(-) > > > > diff --git a/include/hw/virtio/virtio-scsi.h > > b/include/hw/virtio/virtio-scsi.h > > index bf17cc9..9bcda7e 100644 > > --- a/include/hw/virtio/virtio-scsi.h > > +++ b/include/hw/virtio/virtio-scsi.h > > @@ -14,6 +14,7 @@ > > #ifndef _QEMU_VIRTIO_SCSI_H > > #define _QEMU_VIRTIO_SCSI_H > > > > +#include "standard-headers/sys/virtio_scsi.h" > > Why sys/? It's linux/, let's keep it linux/. > > Paolo
Peter requested this change: he felt having portable headers under linux/ is confusing: http://mid.gmane.org/CAFEAcA8QFTWbBZSPjCKzEBBwWZojJL+LDKTPL_F=eCDpDHj=z...@mail.gmail.com Makes sense? -- MST
