> On 03/24/2010 12:19 PM, Richard Henderson wrote: > > On 03/24/2010 02:47 AM, Paolo Bonzini wrote: > >> 1) make CPUState define only common fields. Include CPUState at the > >> beginning of each per-target CPUXYZState. > > > > Irritatingly, the common fields contain quite big TLBs. And the > > offsets from the start of env affect the compactness of the code > > generated from TCG. We really really want the general registers > > to come first to make sure that those offsets fit the host's > > reg+offset addressing mode. > > What about adding a 512-bytes (or more) block or something like that at > the beginning of CPUState with a union, so you can put the per-target > stuff there?
Is it really worth the hassle? Anything touching CPUState is probably going to be CPU specific anyway. Paul
