On 9 February 2015 at 19:43, Christian Borntraeger <borntrae...@de.ibm.com> wrote: > From: Andy Whitcroft <a...@canonical.com> > > checkpatch currently loops on fpu/softfloat.c > Turns out this is fixed in the Linux version of checkpatch. > > So this is a port of Andy Whitcrofts fix from Linux, > Original commit was commit 89a883530fe7 ("checkpatch: ## is not a > valid modifier") > > Cc: Andy Whitcroft <a...@canonical.com> > Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> > --- > scripts/checkpatch.pl | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 5df61f9..8635f4c 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1061,7 +1061,9 @@ sub possible { > case| > else| > asm|__asm__| > - do > + do| > + \#| > + \#\#|
Are you sure this line should end with a '|', given it's the last item in the alternation ? > )(?:\s|$)| > ^(?:typedef|struct|enum)\b > )}x; > -- > 1.9.3 > thanks -- PMM