26.01.2015 14:12, Paolo Bonzini wrote:
> Avoid truncation of a 64-bit long to a 32-bit int, and check for errno
> (especially ERANGE).
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> util/cutils.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/util/cutils.c b/util/cutils.c
> index dbe7412..f227064 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -523,7 +523,7 @@ int parse_debug_env(const char *name, int max, int
> initial)
> {
> char *debug_env = getenv(name);
> char *inv = NULL;
> - int debug;
> + long debug;
>
> if (!debug_env) {
> return initial;
> @@ -532,7 +532,7 @@ int parse_debug_env(const char *name, int max, int
> initial)
> if (inv == debug_env) {
> return initial;
> }
> - if (debug < 0 || debug > max) {
> + if (debug < 0 || debug > max || errno != 0) {
It is not really right to check errno without (re)setting it
before call to strtol().
Thanks,
/mjt
