On Tue, Feb 03, 2015 at 04:46:29PM -0500, John Snow wrote: > Add human-readable command names and other miscellaneous #defines > to help make the code more readable. > > Some of these definitions are not yet used in this current series, > but for convenience and sanity they have been lumped together here, > as it's more trouble than it is worth in a test suite to hand-pick, > one-by-one, which preprocessor definitions are useful per-each test. > > These definitions include: > > ATA Command Mnemonics > Current expected AHCI sector size > FIS magic bytes > REG_H2D_FIS flags > Command Header flags > > Signed-off-by: John Snow <js...@redhat.com> > --- > tests/ahci-test.c | 12 ++++++------ > tests/libqos/ahci.h | 53 > +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+), 6 deletions(-)
I have not checked all the constants against the spec, but the patch looks reasonable. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
pgpCjfZgIw4_t.pgp
Description: PGP signature