On 04/02/2015 16:26, Daniel P. Berrange wrote: > > GIOChannel's advantage is that---even though it may not be used for > > regular migration---integration with chardev would be really easy. > > If we did a QEMUIOChannel that was basically the same as IOChannel, but > with support for iovec writev/readv it'd mostly be drop-in replacement > for the chardev code I guess.
Alternatively, QEMUIOChannel could be a very thin wrapper around GIOChannel. If the QEMUIOChannel is created with qemu_io_channel_unix_get_fd, the QEMUIOChannel could use g_io_channel_unix_get_fd to do writev/readv; otherwise it would just use compatibility code. This relieves you from having to rewrite all the Win32 code that glib already has. > So that version of GIO, with the glib-networking addon > to provide TLS, would mean only running on RHEL-7, which feels like it > is so new it would likely be a showstopper. As long as the non-TLS stuff works on older distros, that would be okay for me. Personally I don't care if VNC-TLS regresses on older distros, either. Paolo
