Hi, I was skimming the list, and noticed:
On 01/31/2015 10:28 AM, Jan Kiszka wrote:
> @@ -1187,6 +1193,10 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> put_packet_binary(s, buf, len + 1);
> break;
> }
> + if (strncmp(p, "Attached", 8) == 0) {
This looks like it'd mishandle a future qAttached2 packet.
It should be doing something like:
if (strncmp(p, "Attached", 8) == 0 &&
(p[8] == '\0' || p[8] == ':')) {
or:
if (strcmp(p, "Attached") == 0 || strncmp(p, "Attached:", 9) == 0) {
Likewise other packets, if they have the same issue.
(I'm not familiar with qemu's stub's internals.)
Thanks,
Pedro Alves
