On 01/26/2015 12:27 PM, Max Reitz wrote: > There are cases where it is probably (!) not necessary to check whether > the return value of blk_bs() is non-NULL, and those are places after > blk_new_open(). In every other place, though, there has to be some check > to make sure that the return value of blk_bs() is non-NULL before it is > used. > > This patch adds that check to hopefully all of the remaining places.
I did not audit for places you might have missed, but concur that these needed it. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > blockdev.c | 18 ++++++++++-------- > hw/block/xen_disk.c | 4 +++- > 2 files changed, 13 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
