On 01/27/2015 12:46 PM, Max Reitz wrote: > Implement 'eject' by calling blockdev-open-tray and > blockdev-remove-medium. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > blockdev.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-)
Hmm. If you decide to enforce node-name only on the low-level command, but still want this high-level command to support BDS->BB lookup for convenience, you might need additional code here. I don't know if that is an argument in favor or against supporting BDS->BB as convenience at the low level. I don't have a strong enough opinion towards either decision, so I'll let others chime in or let your original choice be good enough. Therefore: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
