On 2015-01-27 at 08:51, Denis V. Lunev wrote:
The pattern do { if (fallocate(s->fd, mode, offset, len) == 0) { return 0; } } while (errno == EINTR); ret = translate_err(-errno); will be commonly useful in next patches. Create helper for it.Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Peter Lieven <p...@kamp.de> CC: Fam Zheng <f...@redhat.com> --- block/raw-posix.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 24300d0..2aa268a 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -902,6 +902,18 @@ static int translate_err(int err) return err; }+#if defined(CONFIG_FALLOCATE_PUNCH_HOLE)+static int do_fallocate(int fd, int mode, off_t offset, off_t len) +{ + do { + if (fallocate(fd, mode, offset, len) == 0) { + return 0; + } + } while (errno == EINTR); + return translate_err(-errno);
The translate_err() seems superfluous so far, but won't hurt and I guess the redundancy will disappear in a later patch of this series.
Reviewed-by: Max Reitz <mre...@redhat.com>
