At Fri, 23 Jan 2015 17:24:00 +0900, Teruaki Ishizaki wrote: > > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additional command option. > > But when you create the VDI which doesn't have default object size > with qemu-img command, you specify block_size_shift option. > > If you want to create a VDI of 8MB(1 << 23) object size, > you need to specify following command option. > > # qemu-img create -o block_size_shift=23 sheepdog:test1 100M > > In addition, when you don't specify qemu-img command option, > a default value of sheepdog cluster is used for creating VDI. > > # qemu-img create sheepdog:test2 100M > > Signed-off-by: Teruaki Ishizaki <ishizaki.teru...@lab.ntt.co.jp> > --- > V3: > - Delete the needless operation of buffer. > - Delete the needless operations of request header > for SD_OP_GET_CLUSTER_DEFAULT. > - Fix coding style problems. > > V2: > - Fix coding style problem (white space). > - Add members, store_policy and block_size_shift to struct SheepdogVdiReq > - Initialize request header to use block_size_shift specified by user. > --- > block/sheepdog.c | 140 > ++++++++++++++++++++++++++++++++++++++------- > include/block/block_int.h | 1 + > 2 files changed, 119 insertions(+), 22 deletions(-)
Looks good to me. Acked-by: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp> Thanks, Hitoshi
