On Fri, Jan 16, 2015 at 01:51:53PM -0500, John Snow wrote:
>
>
> On 01/16/2015 08:23 AM, Stefan Hajnoczi wrote:
> >On Fri, Jan 16, 2015 at 09:38:42AM +0800, Fam Zheng wrote:
> >>There is a bug in the recently added sys.platform test, and we no longer
> >>run python tests, because "linux2" is the value to compare here. So do a
> >>prefix match. According to python doc [1], the way to use sys.platform
> >>is "unless you want to test for a specific system version, it is
> >>therefore recommended to use the following idiom":
> >>
> >>if sys.platform.startswith('freebsd'):
> >> # FreeBSD-specific code here...
> >>elif sys.platform.startswith('linux'):
> >> # Linux-specific code here...
> >>
> >>[1]: https://docs.python.org/2.7/library/sys.html#sys.platform
> >>
> >>Signed-off-by: Fam Zheng <f...@redhat.com>
> >>
> >>---
> >>v2: Don't use any().
> >> Explain why prefix match is fine.
> >> (Thanks, Stefan)
> >>---
> >> tests/qemu-iotests/iotests.py | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >Thanks, applied to my block tree:
> >https://github.com/stefanha/qemu/commits/block
> >
> >Stefan
> >
>
> Thanks for this!
>
> fake_internet_karma++It's called Reddit^H^H^H^H^H^HQEMU Gold! Stefan
pgpebcegi3txL.pgp
Description: PGP signature
