Peter Maydell writes:

> I was looking at our confusing mess of memory accessor functions,
> and I realised that partly it was confusing because we have a
> bunch of unnecessary junk lurking in there :-) This series
> attempts to clean things up by removing things we weren't using
> at all or were only using by mistake in a few places:

>  * ldul_*: not used
>  * ld* (ldl, etc): hardly used
>  * ld*_kernel: not used
>  * ld*_raw: hardly used
>  * cpu_{ld,st}{fq,fl}: not used

> The dull parts of this series are removing the unused macros
> and fixing uses of the hardly-used macros so those can be
> deleted too. This series also switches to using inline functions
> rather than macros for the user-only cpu_ld/st* accessors, bringing
> them into line with the softmmu configs. This has the nice
> side effect of letting us get rid of the _raw accessor macros too.
> I've also thrown in a commit which cleans up the doc comments.

I haven't reviewed the patches, but that's a much appreciated cleanup! I was
also trying to make sense of all the variants while implementing guest memory
access tracing (let's see if I can find some time to polish and post the
series).


Thanks!

Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

Reply via email to