On Mon, Jan 12, 2015 at 12:31:31PM +0000, Stefan Hajnoczi wrote: > These patches add an overflow check and a test case for invalid QED headers. > Note that this has no security impact because reading the backing filename is > limited to sizeof(bs->backing_file). > > Stefan Hajnoczi (2): > qed: check for header size overflow > qemu-iotests: add 116 invalid QED input file tests > > block/qed.c | 6 +++ > tests/qemu-iotests/116 | 96 > ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/116.out | 37 ++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 4 files changed, 140 insertions(+) > create mode 100755 tests/qemu-iotests/116 > create mode 100644 tests/qemu-iotests/116.out
Kevin: Thanks for the style suggestion, I have applied your tweak. It does read clearer when the expression checks UINT32_MAX. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
pgpFiu83Rrelw.pgp
Description: PGP signature
