On 03/17/2010 04:48 AM, Riku Voipio wrote:
>>> page_check_range:
>>>
>>> - if (start + len < start)
>>> - /* we've wrapped around */
>>> ...
>>> + if (start + len - 1 < start) {
>>> + /* We've wrapped around. */
>>>
>>> This now blows up with len = 0;
>
>> Confirmed. A quick test with if (len > 0) around and ldconfig.real runs.
>
> Richard, would you be ok with that change? Or should we rather have explicit
>
> if (len == 0) return 0;
My personal preference is
if (len != 0 && start + len - 1 < start)
but don't let that stop anyone checking in any correct variant.
r~
